You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a documentation/comment-only change (chore(container-runner): tighten comments). I diffed every hunk and confirmed no executable Rust code lines were touched, only //////!/// doc-comments, README/Dockerfile/YAML/shell comments, and prose in container-runner/README.md. No behavior change, so no new test coverage is needed for this PR.
Code quality
The trims are good: they collapse multi-sentence doc-comments into tighter prose without losing the load-bearing "why" (e.g. the stop_child/drain_then_stop_child/SIGTERM_BUDGET comments in main.rs and actor.rs still explain the non-obvious invariants, just more concisely).
monitor.rs's module doc-comment removal of the per-source bullet list is safe: the detail now lives on MemSource/CpuSource variant doc-comments (verified those exist with matching content), so nothing was actually lost, just de-duplicated.
Consistent with CLAUDE.md's comment-style rules: em dashes are gone from all added lines, and I did not find any newly-introduced fragmented parenthetical-dash constructions in the added code comments.
Naming: "Cloud Run" to "serverless"/"Rivet Compute"
These renames read correctly in context (e.g. docker-compose.yml, run-host-loadtest.sh, Dockerfile, server.mjs). One pre-existing "Cloud Run" mention remains in container-runner/examples/unity-demo/Dockerfile:5 ("Compute (or any container host: Cloud Run, Fly, a VM, etc.)"), but that one is an example list of generic hosting options, not a reference to Rivet's own platform, so leaving it as-is is fine and not a gap in this PR.
Bugs / correctness
None found. This is a pure comment/prose change with no logic touched.
Performance / security
Not applicable; no code paths changed.
Test coverage
Not applicable; comment-only diff.
Overall: clean, low-risk cleanup. No changes requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.