Skip to content

chore(container-runner): tighten comments - #5589

Open
abcxff wants to merge 1 commit into
stack/feat-container-runner-exit-process-when-the-last-child-stops-ssuvmosofrom
stack/chore-container-runner-tighten-comments-zrxxyxls
Open

chore(container-runner): tighten comments#5589
abcxff wants to merge 1 commit into
stack/feat-container-runner-exit-process-when-the-last-child-stops-ssuvmosofrom
stack/chore-container-runner-tighten-comments-zrxxyxls

Conversation

@abcxff

@abcxff abcxff commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@claude

claude Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review

This is a documentation/comment-only change (chore(container-runner): tighten comments). I diffed every hunk and confirmed no executable Rust code lines were touched, only //////!/// doc-comments, README/Dockerfile/YAML/shell comments, and prose in container-runner/README.md. No behavior change, so no new test coverage is needed for this PR.

Code quality

  • The trims are good: they collapse multi-sentence doc-comments into tighter prose without losing the load-bearing "why" (e.g. the stop_child/drain_then_stop_child/SIGTERM_BUDGET comments in main.rs and actor.rs still explain the non-obvious invariants, just more concisely).
  • monitor.rs's module doc-comment removal of the per-source bullet list is safe: the detail now lives on MemSource/CpuSource variant doc-comments (verified those exist with matching content), so nothing was actually lost, just de-duplicated.
  • Consistent with CLAUDE.md's comment-style rules: em dashes are gone from all added lines, and I did not find any newly-introduced fragmented parenthetical-dash constructions in the added code comments.

Naming: "Cloud Run" to "serverless"/"Rivet Compute"

  • These renames read correctly in context (e.g. docker-compose.yml, run-host-loadtest.sh, Dockerfile, server.mjs). One pre-existing "Cloud Run" mention remains in container-runner/examples/unity-demo/Dockerfile:5 ("Compute (or any container host: Cloud Run, Fly, a VM, etc.)"), but that one is an example list of generic hosting options, not a reference to Rivet's own platform, so leaving it as-is is fine and not a gap in this PR.

Bugs / correctness
None found. This is a pure comment/prose change with no logic touched.

Performance / security
Not applicable; no code paths changed.

Test coverage
Not applicable; comment-only diff.

Overall: clean, low-risk cleanup. No changes requested.

@abcxff
abcxff force-pushed the stack/feat-container-runner-exit-process-when-the-last-child-stops-ssuvmoso branch from 332c1a8 to 87b61cb Compare August 24, 2026 14:46
@abcxff
abcxff force-pushed the stack/chore-container-runner-tighten-comments-zrxxyxls branch from 102498a to 2e9fde1 Compare August 24, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant